Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify SimTx SimGasUsed log print and add AVC-PResMsg #206

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

modify SimTx SimGasUsed log print and add AVC-PResMsg #206

wants to merge 3 commits into from

Conversation

bylingo
Copy link

@bylingo bylingo commented Aug 2, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@bylingo bylingo marked this pull request as ready for review August 3, 2023 07:13
@codecov-commenter
Copy link

Codecov Report

Merging #206 (2b314b6) into dev (e6ed0b9) will decrease coverage by 4.80%.
The diff coverage is n/a.

❗ Current head 2b314b6 differs from pull request most recent head 22b298c. Consider uploading reports for the commit 22b298c to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #206      +/-   ##
==========================================
- Coverage   34.45%   29.65%   -4.80%     
==========================================
  Files         430       55     -375     
  Lines       44883     5847   -39036     
==========================================
- Hits        15464     1734   -13730     
+ Misses      28271     3936   -24335     
+ Partials     1148      177     -971

see 375 files with indirect coverage changes

@okx okx deleted a comment from bylingo Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann-sjtu yann-sjtu yann-sjtu approved these changes

@chengzhinei chengzhinei Awaiting requested review from chengzhinei

@KamiD KamiD Awaiting requested review from KamiD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bylingo @codecov-commenter @yann-sjtu